Merge develop into main - #75
Merged
Merged
Conversation
…eme/Unify' token set
…nk' 'theme' token sets
Primitive layer:
z-index.sub-9999 {-9999}
z-index.1 {1}
z-index.100 {100}
z-index.200 {200}
z-index.300 {300}
z-index.400 {400}
z-index.500 {500}
z-index.600 {600}
z-index.700 {700}
z-index.800 {800}
z-index.900 {900}
Theme (Semantic) layer:
z-index.dropdown { z-index.100 }
z-index.backdrop { z-index.200 }
z-index.modal { z-index.800 }
z-index.alert-toast { z-index.800 }
…gma-only feature: marking body, label, link tokens as figmaOnly..
accordion
alert
breadcrumb
button
modal
badge
link
pagination
tabs
list-item
tag
table
stepper
date-picker
loader
-----------------------------------
Badge tokens
Changing token value of:
component.badge.default.font-size
From:
{size-space.2-5-x}
To
0.625rem
Changing token value of:
component.badge.large.font-size
From:
{size-space.3-5-x}
To
{font-size.04}
-----------------------------------
Breadcrumb tokens
Changing token name from:
component.breadcrumb.font-size
To
component.breadcrumb.default.font-size
Adding additional token for the small size:
component.breadcrumb.small.font-size
Changing token name from:
component.breadcrumb.line-height
To
component.breadcrumb.default.line-height
Adding additional token for the small size:
component.breadcrumb.small.line-height
-----------------------------------
Loader tokens
Changing token value of:
component.loader.large.font-weight
From:
{font-weight.regular}
To
{font-weight.medium}
-----------------------------------
Modal tokens
Changing token value of:
component.modal.content.font-size
From:
{font-size.04}
To
{font-size.body.default}
…t save last update.
…d Partnerbank theme. Token vlaues need to be the same type across themes (ie: Theme A is a number value, but Theme B is a string, this will cause the token to not be published as a variable in Figma)
--made-time-moderate-01
--made-time-moderate-02
--made-time-moderate-fast-01
--made-time-moderate-fast-02
--made-time-slow-01
--made-time-slow-02
Teams should instead use our new motion-duration tokens
"duration": {
"shortest": {
"$type": "duration",
"$value": "50ms"
},
"short": {
"$type": "duration",
"$value": "150ms"
},
"medium": {
"$type": "duration",
"$value": "200ms"
},
"default": {
"$type": "duration",
"$value": "300ms"
},
"long": {
"$type": "duration",
"$value": "400ms"
},
"longest": {
"$type": "duration",
"$value": "500ms"
}
}
},
…e naming of half step tokens when converted to camelCase, the current naming creates duplicate for these case (1-5 and 15 etc) and a conflict. The solution is to rename the following tokens from: size-space.0-25-px size-space.0-5-px size-space.1-5-px size-space.2-5-px size-space.3-5-px TO: size-space.0point25-px size-space.0point5-x size-space.1point5-x size-space.2point5-x size-space.3point5-x
From: size-space.0point25-px to: size-space.0point25-x
component.card.padding-x
component.card.padding-y
From: {size-space.0-x}
to: {size-space.5-x}
…esn't change across different modes). This is being added to the Theme and Mode sets. Met with AH on April 30th and discussed the need for this token specifically for card text on a background that is an image. “A persistent color that does not change across different modes (light and dark). Use this token sparingly. Its primary use is for text colors on cards that use images as backgrounds. “
…n't change across different modes). It makes sense to also add this type of token to our icon set of tokens. “A persistent color that does not change across different modes (light and dark). Use this token sparingly.” Also realised that the text.fixed token was only added to the Unify theme, adding this into the Mastercard and Partnerbank themes.
…tercard augmetned color palette.
…ponent tokens in the MODE set. These were incorrectly referencing semantic tokens in the Theme set instead of component-level tokens in the Theme set.
…nents: Accordion title; Alert Title; Badge label; Button label; Tab label. This is so that the -2% can be applied to certain labels in the Mastercard theme without affecting other themes
component.button.default.padding-x [{size-space.6-x}]
component.button.small.padding-x [{size-space.4-x}]
border.radius.large > from {size-space.2-x} to {border-radius.08}
…s token references:
component.alert.border-radius
changing from {border.radius.default} to {border.radius.large}
component.modal.border-radius
changing from {border.radius.default} to {border.radius.large}
component.card.border-radius
changing from {border.radius.default} to {border.radius.large}
component.menu.border-radius
changing from {border.radius.default} to {border.radius.large}
component.date-picker.border-radius
changing from {border.radius.default} to {border.radius.large}
component.date-picker.border-radius
changing from {border.radius.default} to {border.radius.large}
component.drawer.border-radius
changing from {border.radius.default} to {size-space.8-x}
…ders , Icon colors.
from Gray.200 to 300 color.background.disabled-mode-dark from Gray.1200 to 1400
… from gray 1800 to gray 500
Changing value from a solid grey to transparent:
{color.background.surface.transparent-mode-dark}
… discussed with MC
…ent-level letter spacing tokens in the Unify theme. .Setting them back to 0 for the Unify Theme only.
Figma unify mastercard 2 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
{{short description}}
Changelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}