Repository navigation
deny: ignore RUSTSEC-2024-0449 (unsafe-libyaml unmaintained) - #39766
Merged
Merged
Conversation
unsafe-libyaml is pulled in by serde_yaml, which kube-client depends on. No safe upgrade is available. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bosconi
approved these changes
Oct 13, 2026
bosconi
left a comment
bosconi
left a comment
Member
There was a problem hiding this comment.
Looks good. One doc suggestion.
Comment on lines
+333
to
+334
| # `unsafe-libyaml` is unmaintained. Pulled in by `serde_yaml`, which | ||
| # `kube-client` depends on. No safe upgrade is available. |
Member
There was a problem hiding this comment.
-
mz-debug(Cargo.toml#L31) andmz-metrics-catalog(Cargo.toml#L21) depend onserde_yamldirectly, both only to serialize (k8s_dumper.rs#L108, main.rs#L576). -
kube-client4.0.0 and later depend onserde-saphyrinstead ofserde_yaml, which build(deps): bump kube to 4.2, k8s-openapi to 0.28, and k8s-controller to 0.14 #39355 (draft, waiting on a k8s-controller release) brings in. Its lock diff dropsserde_yamlonly fromkube-client, so after it lands the advisory still fires through the two crates above.
Suggested change
| # `unsafe-libyaml` is unmaintained. Pulled in by `serde_yaml`, which | |
| # `kube-client` depends on. No safe upgrade is available. | |
| # `unsafe-libyaml` is unmaintained. Pulled in by `serde_yaml`, which | |
| # `mz-debug` and `mz-metrics-catalog` use directly and `kube-client` 3.x | |
| # requires. kube-client 4 uses `serde-saphyr` instead. |
Member
Author
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Nightly "Security advisories" job fails on the new RUSTSEC-2024-0449 advisory, which marks
unsafe-libyamlas unmaintained. The crate arrives viaserde_yaml, whichkube-clientenables unconditionally through itsclientfeature for kubeconfig parsing. No safe upgrade exists, so this adds the advisory to thedeny.tomlignore list.Posted by Claude Code.
🤖 Generated with Claude Code