<feature>[errorcode]: ZSTAC-86666 update backup conflict error mappings

[zstack-robot-2]

Summary

Update global error-code mappings for backup/CBT/CDP scheduler conflict messages on 5.5.38.

Changes

• Updated 10 global error mapping JSON files.
• Removed scheduler text placeholders from conflict message mappings.

Testing

• No Java compile needed: zstack MR changes JSON i18n mappings only.
• CI pipeline
• Manual test

Notes

• Source branch is currently 5 commits behind upstream/5.5.38; rebase is recommended before merge if target moved materially.

Resolves: ZSTAC-86666

sync from gitlab !10732

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 40 minutes

Limit details: You’ve used the included review currently available. Your 96 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 3f4ec996-c643-42d3-8887-bd15cd028ced

📥 Commits

Reviewing files that changed from the base of the PR and between 3dcb52e and cef2558.

⛔ Files ignored due to path filters (10)

• conf/i18n/globalErrorCodeMapping/global-error-de-DE.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-en_US.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-fr-FR.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-id-ID.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-ja-JP.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-ko-KR.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-ru-RU.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-th-TH.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-zh_CN.json is excluded by !**/*.json
• conf/i18n/globalErrorCodeMapping/global-error-zh_TW.json is excluded by !**/*.json

📒 Files selected for processing (5)

• header/src/main/java/org/zstack/header/storage/snapshot/VolumeSnapshotConstant.java
• storage/src/main/java/org/zstack/storage/snapshot/VolumeSnapshotManagerImpl.java
• storage/src/main/java/org/zstack/storage/snapshot/VolumeSnapshotTreeBase.java
• storage/src/main/java/org/zstack/storage/volume/VolumeBase.java
• utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)

Could not fetch remote config from http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml: TimeoutError: The operation was aborted due to timeout

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

---

_{Comment @coderabbitai help to get the list of available commands.}

[ZStack-Robot]

Comment from yingzhe.hu:

Code Review

代码量不大，但两个契约问题都不能带过去：i18n 会静默吞掉冲突资源信息，MR 又把包含 13 个字段的 schema migration 写成 JSON-only。

已读真实文件核对：11 个 changed files；10 个 locale JSON 均可被 jq 解析；git diff --check PASS；未运行 populated DB upgrade、startup/schema validation、CI/manual。

Ponytail

Lean already. Ship.

Findings

#	严重程度	分类	文件	问题描述	修复建议
1	🟡 Major	API/i18n 契约	global-error-en_US.json:2646	模板删除占位符，调用端 formatArgs 被静默丢弃	恢复参数契约；不同语义拆独立 error code
2	🟡 Major	Review readiness	V5.5.38__schema.sql:12	MR 声称 JSON-only，却新增三个表共 13 个字段	修正 MR 元数据并补存量库 upgrade/startup 验证

结论

REVISION_REQUIRED 🚫

回归风险：高。错误定位信息退化，且 schema 发布证据缺失。

合并阻塞：#1, #2

复审硬性要求：补齐 i18n 参数保真测试、存量数据库升级与 premium startup/schema validation。

---

Review by Codex + Ponytail

---

Review Tracker: ZSTAC-86666

Rounds: R1=block

#	Sev	Cat	Repo	File	Finding	R1
1	CRIT	数据一致性	premium	VolumeBackupUtils.java	失败补偿按 groupUuid+generationUuid 整组删除，会连同同 generati…	🔴
2	CRIT	ZStack async-only	premium	VolumeBackupManagerImpl.java	新增 java.util.concurrent.Future，命中 async-only CI 红…	🔴
3	MAJ	并发正确性	premium	BackupManager.java	snapshot 只有瞬时 findConflict，没有同 VM reservation，仍有 …	🔴
4	MAJ	测试证据	premium	VolumeBackupManagerImpl.java	大型 owner/epoch/reconcile 状态机只有 compile 证据，无 recon…	🔴
5	MAJ	数据库	premium	VolumeBackupManagerImpl.java	VM GLock 临界区内逐条 reservation 执行条件 UPDATE。	🔴
6	MAJ	API/i18n 契约	zstack	global-error-en_US.json	10042/10049 模板删除占位符，premium 传入的冲突资源 formatArgs 被静…	🔴
7	MAJ	Review readiness	zstack	V5.5.38__schema.sql	MR 声称 JSON-only，实际新增三个存量表共 13 个字段且无 upgrade/start…	🔴
8	min	测试路径	premium	CbtRestrictionsCase.groovy	integration case 直接写 DB/发送内部 Msg，绕过 SDK 与真实 reser…	🔴

Progress: ░░░░░░░░░░ 0/8 resolved (0%)
2 critical issue(s) still open