Skip to content

Address a pointSize NaN bug#126

Merged
TiagoCavalcante merged 5 commits into
mainfrom
pointSize-bug
Apr 18, 2026
Merged

Address a pointSize NaN bug#126
TiagoCavalcante merged 5 commits into
mainfrom
pointSize-bug

Conversation

@rocky

@rocky rocky commented Apr 10, 2026

Copy link
Copy Markdown
Member

Fixes #125

There are probably deeper issues in setting the pointSize.

@rocky rocky assigned rocky and TiagoCavalcante and unassigned rocky Apr 10, 2026
@rocky rocky force-pushed the pointSize-bug branch 2 times, most recently from 8b7da6a to 7a17d98 Compare April 10, 2026 20:32
This is a more solid replacement of the "point size is NaN" bug fix.
@TiagoCavalcante

Copy link
Copy Markdown
Collaborator

Hi @rocky. I've implemented a more reliable fix: pass the container size as a uniform which is updated whenever the container size changes. It should work well now.
The tests haven't passed for some time (#107), but it is working.

@TiagoCavalcante TiagoCavalcante merged commit be01375 into main Apr 18, 2026
2 of 3 checks passed
@TiagoCavalcante TiagoCavalcante deleted the pointSize-bug branch April 18, 2026 03:21
@rocky

rocky commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

@TiagoCavalcante Many many thanks!

@rocky

rocky commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

@TiagoCavalcante: Can we get a release on npm please?

I've pushed this to npmjs.org. Thanks again!

@rocky

rocky commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

(One other thing that might be interesting, but not needed right now, is to see if we can update the three.js version.)

@rocky

rocky commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

@TiagoCavalcante: Can we get a release on npm, please?

I see that I can do. I will do, but there will be another PR to change Mathics to Mathics3.

@TiagoCavalcante

Copy link
Copy Markdown
Collaborator

(One other thing that might be interesting, but not needed right now, is to see if we can update the three.js version.)

I've updated it to the latest version (r184) in #129.

@rocky

rocky commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

(One other thing that might be interesting, but not needed right now, is to see if we can update the three.js version.)

I've updated it to the latest version (r184) in #129.

You're the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gl_PointSize is NaN when using Point

2 participants