Add a session handler to migrate from pdo to redis, add managed gc times#2127
Open
BentiGorlich wants to merge 5 commits into
Open
Add a session handler to migrate from pdo to redis, add managed gc times#2127BentiGorlich wants to merge 5 commits into
BentiGorlich wants to merge 5 commits into
Conversation
- symfony uses the php default garbage collector probabilities, but that is set to 0 in debian and ubuntu, so manage it ourselves so the sessions get cleared out - add a service definition for redis, which the redis session handler needs, this includes splitting up the dsn in our .env file
BentiGorlich
added
dependencies
Member
Author
|
As a note, we moved to the PdoSessionHandler in #1145. Before that we used our redis dsn as the |
Collaborator
|
Please don't forget the |
Collaborator
|
As it runs well on some servers so far, do you think this is ready for review? |
blued-gear
requested changes
Jul 6, 2026
| - '%env(int:REDIS_PORT)%' | ||
|
|
||
| # uncomment the following if your Redis server requires a password | ||
| - auth: |
Collaborator
There was a problem hiding this comment.
it says 'uncomment the following' but it is already not commented; please change the comment or comment-out the code
| @@ -89,7 +89,9 @@ TRUSTED_PROXIES= | |||
|
|
|||
| # Redis | |||
Collaborator
There was a problem hiding this comment.
These changes need to be applied to the .devcontainer env file too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MigratingSessionHandlerthat writes all sessions to the RedisSessionHandler as well, so we can move towards that