Skip to content

test: cover poster page tiling calculations - #48

Merged
McanKul merged 1 commit into
McanKul:developmentfrom
strongdan:agent/test-poster-page-tiling
Aug 17, 2026
Merged

test: cover poster page tiling calculations#48
McanKul merged 1 commit into
McanKul:developmentfrom
strongdan:agent/test-poster-page-tiling

Conversation

@strongdan

Copy link
Copy Markdown
Contributor

Summary

  • add focused unit coverage for A4 point conversion and orientation swapping
  • cover tile-count fit tolerance, overflow, multi-sheet, and overlap behavior
  • verify explicit and automatic grid orientation, count invariants, and deterministic ties
  • cover A-series labels in both orientations and custom-size rounding

No production code was changed; the existing helpers satisfy the specified behavior.

Verification

  • npm test -- src/lib/paper.test.ts — 14 tests passed
  • npm run typecheck — passed

Closes #18

@McanKul McanKul left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, Dan — this is a focused and thorough second contribution. The boundary, overlap, orientation, and size-label cases all look good; I also verified the targeted tests, full frontend suite, typecheck, and production build locally. Approved!

@McanKul
McanKul marked this pull request as ready for review August 17, 2026 02:35
@McanKul
McanKul merged commit c38f3e6 into McanKul:development Aug 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants