Skip to content

Clarify expected result of GetECG when no ECG present. #115

Description

@SteveKauffman

When the TestViewer.exe is run on an image that has no ECG data, we were returning an EcgSeries object with 0 samples.

Unfortunately this causes TestViewer's DrawEcg() method to attempt dividing by zero.

I think we need to clarify what the expected result of GetECG() is in the case that there is no ECG data associated with the image. In C++, it makes sense for GetECG(EcgSeries* ecg) to set 'ecg' to 0. Unclear to me the impact on C# clients of the interface using EcgSeries ecg = m_source.GetECG().

Thoughts?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions