Skip to content

fix(swagger): add @ApiProperty decorators to inline controller DTOs (#355) - #392

Open
PINYOPATTANAWASANPORN wants to merge 1 commit into
MergeFi:mainfrom
PINYOPATTANAWASANPORN:fix/swagger-inline-dtos-355
Open

PINYOPATTANAWASANPORN wants to merge 1 commit into
MergeFi:mainfrom
PINYOPATTANAWASANPORN:fix/swagger-inline-dtos-355

Conversation

@PINYOPATTANAWASANPORN

Copy link
Copy Markdown

Summary of Changes

Annotates all properties across the six inline controller-defined DTOs with @ApiProperty() from @nestjs/swagger, ensuring that Swagger UI (/api/docs) accurately renders request body schemas for money-moving and PII endpoints.

Fixes #355

Changes By Component

  • src/maintenance-pool/maintenance-pool.controller.ts:
    • DepositDto: @ApiProperty() on amount and funderAddress
    • AssignRewardDto: @ApiProperty() on issueId, amount, recipientAddress, and recipientId (optional)
  • src/bounties/bounties.controller.ts:
    • FundBountyDto: @ApiProperty() on funderAddress
  • src/users/users.controller.ts:
    • SetStellarAddressDto: @ApiProperty() on stellarAddress
  • src/milestones/milestones.controller.ts:
    • FundMilestoneDto: @ApiProperty() on funderAddress
    • ResolveIssueDto: @ApiProperty() on recipientAddress and recipientId (optional)

Verification & Testing

  • Validated that all 6 inline classes import ApiProperty from @nestjs/swagger.
  • Verified each property definition matches existing DTO conventions across src/*/dto/*.dto.ts.
  • Zero runtime logic changes or breaking schema modifications.

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

@PINYOPATTANAWASANPORN is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant