fix(bounties): atomic status update in expireOverdue to prevent race condition (#460) - #468
Open
Proxima84-code wants to merge 3 commits into
Open
Proxima84-code wants to merge 3 commits into
Proxima84-code wants to merge 3 commits into
Conversation
|
@Proxima84-code is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
…cross test suites
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #460 by ensuring that expiring overdue bounties (
expireOverdue) is executed as an atomic database operation, eliminating race conditions between concurrent status checks and status transitions. Additionally, synchronizes the branch with current changes frommain, resolving merge conflicts and aligning controller signatures, TypeORM query types, and NestJS test module providers.Changes
BountiesService.expireOverdueto transition overdue bounties (OPEN,FUNDED,CLAIMED) toEXPIREDatomically. Mock and state transitions verified inbounties.service.spec.ts.getRepositoryToken(IdempotencyKey)andReflectorinbounties.controller.spec.tsto satisfy dependencies required byIdempotencyInterceptor.bounties.controller.spec.tsforcreate,fund, andrefundto reflect injectedcallerUserIdand passedundefined as anyfor absent query parameter validation.sponsorIdmatchingcallerUserIdin mock objects to pass authorization checks inrefundtests.poolService.createsignature inmaintenance-pool.controller.ts, handled optionalrecipientIdtyping inmaintenance-pool.service.ts, and updated test calls inteams.controller.spec.ts.Verification
npx tsc --noEmit(0 errors)npm test -- src/bounties/(4/4 test suites passed, 39/39 tests passed)Closes #460