fix(maintenance-pool): drop broken pessimistic lock in deposit (#457) - #470
Open
Proxima84-code wants to merge 1 commit into
Open
Proxima84-code wants to merge 1 commit into
Proxima84-code wants to merge 1 commit into
Conversation
|
@Proxima84-code is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #457.
Root Cause
In
MaintenancePoolService.deposit(),createQueryBuilder('pool').setLock('pessimistic_write')was executed outside an active transaction. TypeORM throwsPessimisticLockTransactionRequiredErrorwhen executing pessimistic locks without an active transaction runner, causing allPOST /maintenance-pool/:id/depositrequests to crash with HTTP 500. Furthermore, wrapping the entire call in a database transaction would hold database row locks during multi-second Soroban RPC network calls (escrowService.fund).Fix
deposit()and replaced it with a directfindOne()read.update({ id, escrowId: null }, { escrowId })), which already handles concurrent first-time deposit races safely without connection starvation.escrow.service.tsand updatedmaintenance-pool.service.spec.ts.