Skip to content

fix(github): allow redelivery and re-processing of failed webhooks (#317) - #476

Open
Proxima84-code wants to merge 1 commit into
MergeFi:mainfrom
Proxima84-code:fix/github-webhook-failed-status-317
Open

Proxima84-code wants to merge 1 commit into
MergeFi:mainfrom
Proxima84-code:fix/github-webhook-failed-status-317

Conversation

@Proxima84-code

Copy link
Copy Markdown

Resolves #317.

Summary of Changes

  • Controller: Throws InternalServerErrorException (HTTP 500) when webhook processing status is FAILED, prompting GitHub to schedule an automatic redelivery.
  • Service: Intercepts redeliveries matching an existing deliveryId in FAILED status, resets status to RECEIVED (error and processedAt to null), and re-executes business logic instead of dropping the event as a duplicate.
  • Unit Tests:
    • Added test case verifying HTTP 500 response on failed event processing in controller.
    • Added test case verifying business logic re-execution for retry deliveries in service.
    • Fixed mock definitions across webhook test suites.

@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@Proxima84-code is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GithubWebhooksController.handle always returns 202 even when handleEvent marks the event FAILED, and no job ever reprocesses FAILED WebhookEvent rows

1 participant