fix(common): use canonical BPS_DENOMINATOR in split.rs - #411
Merged
chonilius merged 1 commit intoSep 27, 2026
Merged
Conversation
split.rs declared its own private `const BPS_DENOMINATOR: i128 = 10_000;` instead of importing the one centralized in mergefi-common's lib.rs (MergeFi#163). compute_split now uses `crate::BPS_DENOMINATOR`, so the fee/payout math can't silently drift from the shared constant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@DooseWayo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split.rs declared its own private
const BPS_DENOMINATOR: i128 = 10_000;instead of importing the one centralized in mergefi-common's lib.rs (#163). compute_split now usescrate::BPS_DENOMINATOR, so the fee/payout math can't silently drift from the shared constant.Summary
Related issues
Closes #327
Closes #328
Closes #329
Closes #330
Changes
Test plan
make test)Checklist
maincargo fmtandcargo clippyare clean