Skip to content

fix(milestones): return typed errors for archived contributions - #422

Merged
chonilius merged 1 commit into
MergeFi:mainfrom
edehvictor:fix-milestone-archived-contributions-418
Sep 28, 2026
Merged

chonilius merged 1 commit into
MergeFi:mainfrom
edehvictor:fix-milestone-archived-contributions-418

Conversation

@edehvictor

Copy link
Copy Markdown
Contributor

Closes #418
Closes #416
Closes #44
Closes #12

Summary

Prevents milestone contribution operations from panicking when an existing contribution record has been archived or is otherwise unavailable in persistent storage.

Changes

  • Replaces the existing-contributor scan’s unsafe unwrap() with ContributionNotFound propagation.
  • Applies the same typed error path when updating an existing contribution after the token transfer is measured.
  • Aligns contribute with the contract’s established missing-record handling used by adjacent milestone flows.
  • Preserves successful contribution behavior and does not change storage layout, authorization, or payout logic.

Scope

This PR delivers the narrow archived-record reliability fix for milestone contributions. The treasury invariant, maintenance-pool recipient validation, and full cross-contract event schema listed above remain independent larger changes despite being included for assignment tracking.

Verification

No dependencies were installed and no builds, tests, or CI checks were run, per request.

@vercel

vercel Bot commented Sep 28, 2026

Copy link
Copy Markdown

@edehvictor is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 28, 2026

Copy link
Copy Markdown

@edehvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@chonilius
chonilius merged commit 2f9296c into MergeFi:main Sep 28, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment