Conversation
Add /// doc comments to get_admin, get_oracle, get_treasury, get_fee_bps, get_version, and get_max_sponsors in contracts/escrow/src/lib.rs. These were the only public functions in the file lacking documentation, an inconsistency with the rest of the module. Each comment describes what the function returns; get_version also notes its non-obvious default of 0 when the version flag has not been set.
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@alfeedrips Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add /// doc comments to get_admin, get_oracle, get_treasury, get_fee_bps, get_version, and get_max_sponsors in contracts/escrow/src/lib.rs.
These were the only public functions in the file lacking documentation, an inconsistency with the rest of the module. Each comment describes what the function returns; get_version also notes its non-obvious default of 0 when the version flag has not been set.
Summary
Related issues
Changes
Closes #331
Closes #332
Closes #333
Closes #335
Test plan
make test)Checklist
maincargo fmtandcargo clippyare clean