fix: return ArithmeticOverflow instead of panicking on i128 overflow - #429
Merged
chonilius merged 1 commit intoSep 29, 2026
Merged
Conversation
Release profile sets overflow-checks=true + panic=abort, so any unchecked i128 op (pool.balance += amount, total_deposited += amount, total*fee_bps, distributable*bps, allocated += share, remaining*amount, deadline + GRACE_PERIOD, balance_after - balance_before) aborts the whole transaction. Convert every reachable site in escrow, milestones, maintenance-pool, and common::compute_split to checked_*/saturating_* ops returning a new ArithmeticOverflow error (SplitError::Overflow in common, mapped per-contract), so overflows are graceful errors that leave state untouched rather than aborts.
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Akatenvictor Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release profile sets overflow-checks=true + panic=abort, so any unchecked i128 op (pool.balance += amount, total_deposited += amount, totalfee_bps, distributablebps, allocated += share, remainingamount, deadline + GRACE_PERIOD, balance_after - balance_before) aborts the whole transaction. Convert every reachable site in escrow, milestones, maintenance-pool, and common::compute_split to checked_/saturating_* ops returning a new ArithmeticOverflow error (SplitError::Overflow in common, mapped per-contract), so overflows are graceful errors that leave state untouched rather than aborts.
Summary
Related issues
Closes #7
Closes #9
Closes #18
Closes #27
Changes
Test plan
make test)Checklist
maincargo fmtandcargo clippyare clean