Skip to content

ci(mergify): add the Approved-by trailer to squash merges - #12

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/approved-by-trailer/add-approved-trailer-squash-merges--be1a2571
Oct 19, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/approved-by-trailer/add-approved-trailer-squash-merges--be1a2571

Conversation

@jd

@jd jd commented Oct 16, 2026

Copy link
Copy Markdown
Member

The default queue rule squashes with the PR title and body. Adding
trailers: [approved-by] to its commit_message_format appends an
Approved-by: line for each approving reviewer, so the commit on main
records who approved the change.

The dependencies rule merges with fast-forward, which keeps the
original commits and has no message to format, so it is left as is.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

The `default` queue rule squashes with the PR title and body. Adding
`trailers: [approved-by]` to its `commit_message_format` appends an
`Approved-by:` line for each approving reviewer, so the commit on main
records who approved the change.

The `dependencies` rule merges with fast-forward, which keeps the
original commits and has no message to format, so it is left as is.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Change-Id: Ibe1a2571ded79dc91983bb840af103105af1e484
@mergify

mergify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 📃 Configuration Change Requirements

Mergify configuration change

  • any of:
    • check-success = @mergify/Configuration changed
    • check-success = @mergify/Configuration has been deleted

🟢 🤖 Continuous Integration

  • all of:
    • check-success=all-greens

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify
mergify Bot deployed to Mergify Merge Protections October 16, 2026 23:20 Active
@mergify
mergify Bot requested a review from a team October 16, 2026 23:21
@jd
jd marked this pull request as ready for review October 17, 2026 08:34
Copilot AI balanced review requested due to automatic review settings October 17, 2026 08:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@jd
jd requested a review from a team October 17, 2026 15:04
@mergify

mergify Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-10-19 07:25 UTC · Rule: default · triggered by merge protections
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-10-19 07:26 UTC · at a604a73b1f1856b386b87d8aacba6c49e30f3212 · squash

This pull request spent 11 seconds in the queue, including 1 second running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Oct 19, 2026
@mergify
mergify Bot merged commit a604a73 into main Oct 19, 2026
10 of 11 checks passed
@mergify
mergify Bot deleted the devs/jd/jd/approved-by-trailer/add-approved-trailer-squash-merges--be1a2571 branch October 19, 2026 07:26
@mergify mergify Bot removed the queued label Oct 19, 2026

This branch was successfully deployed

1 active deployment
Mergify Merge Protections — 4c0fec81 Deployed Oct 16, 2026 by mergify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants