Skip to content

ci(mergify): require one approving review instead of two - #14

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/one-approving-review/require-one-approving-review-instead-two--dedcfdd8
Oct 20, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/one-approving-review/require-one-approving-review-instead-two--dedcfdd8

Conversation

@jd

@jd jd commented Oct 18, 2026

Copy link
Copy Markdown
Member

The "👀 Review Requirements" merge protection asked for two approvals
on every pull request not opened by a bot. One is enough for this
repository, so default_review_cond now reads
#approved-reviews-by>=1. The dependabot, renovate and mergify-ci-bot
exemptions are unchanged.

Nothing on the GitHub side asks for more: main has no branch
protection, and no repository or organization ruleset applies to it,
so this line was the only place two approvals were required.

Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com

The "👀 Review Requirements" merge protection asked for two approvals
on every pull request not opened by a bot. One is enough for this
repository, so `default_review_cond` now reads
`#approved-reviews-by>=1`. The dependabot, renovate and mergify-ci-bot
exemptions are unchanged.

Nothing on the GitHub side asks for more: main has no branch
protection, and no repository or organization ruleset applies to it,
so this line was the only place two approvals were required.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Change-Id: Idedcfdd85fa1a873092fba08089419afb9251639
@mergify
mergify Bot deployed to Mergify Merge Protections October 18, 2026 16:08 Active
@mergify

mergify Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 📃 Configuration Change Requirements

Mergify configuration change

  • any of:
    • check-success = @mergify/Configuration changed
    • check-success = @mergify/Configuration has been deleted

🟢 🤖 Continuous Integration

  • all of:
    • check-success=all-greens

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = mergify-ci-bot
    • author = renovate[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify
mergify Bot requested a review from a team October 18, 2026 16:09
@jd
jd marked this pull request as ready for review October 19, 2026 12:46
Copilot AI balanced review requested due to automatic review settings October 19, 2026 12:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@jd
jd requested a review from a team October 20, 2026 06:26
@mergify

mergify Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 minute 9 seconds in the queue, including 39 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Oct 20, 2026
@mergify mergify Bot mentioned this pull request Oct 20, 2026
14 of 17 tasks
@mergify
mergify Bot merged commit ccdfe8b into main Oct 20, 2026
10 of 11 checks passed
@mergify
mergify Bot deleted the devs/jd/jd/one-approving-review/require-one-approving-review-instead-two--dedcfdd8 branch October 20, 2026 07:22
@mergify mergify Bot removed the queued label Oct 20, 2026

This branch was successfully deployed

1 active deployment
Mergify Merge Protections — 18ac6aa1 Deployed Oct 18, 2026 by mergify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants