Draft
Conversation
Implement a filtering system that lets users filter map features by field values. Supports text, number, and date/datetime range filters with calendar picker integration. - FilterController manages filter state, expression generation, and layer subset string application - Filter panel UI with per-layer sections and field-type-aware inputs - Date filters use MMCalendarDrawer with time picker for datetime fields and date-only picker for date fields - Timezone-aware: converts local time to UTC for GeoPackage comparison - Seconds/milliseconds normalization for inclusive time ranges - Individual date clear buttons and range validation - Filter button on map, settings toggle, feature list integration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Switch the map filter button from outline to filled icon when filters are applied, making the active state more visually distinct. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Detect ValueMap/ValueRelation editor widgets and show dropdown filter
instead of text/number input. Options are lazy-loaded via getDropdownOptions()
with search and a 100-item limit for large ValueRelation tables.
Multi-value fields (AllowMulti) use LIKE-based expressions to match
the {k1,k2} storage format. Selected items are always included in
the options list even when beyond the limit.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage Report for CI Build 24457518310Coverage decreased (-0.007%) to 58.457%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postponed for now
TODO:
MMBaseInputinstead ofMMBaseSingleLineInputUniqueValuesFilterModel::populate()we should pass layer instead ofFilterController