Fix undefined ${manifest} in vcpkg auto-update workflow#6336
Merged
Conversation
The update-vcpkg-tag job failed in the Bump vcpkg step with
"jq: error: Could not open file" because ${manifest} was never
defined. Use the hard-coded manifest path ./thirdparty/vcpkg/vcpkg.json
that the neighboring sed lines already reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scheduled
Update Vcpkg Tagworkflow (update-vcpkg-tagjob) failed in the Bump vcpkg step with:Root cause
Introduced in #6230 ("Add experimental vcpkg manifest file", merged 2026-06-09). That PR added the manifest-baseline logic to the Bump vcpkg step, including a
jqcall that references an undefined${manifest}variable, sojqalways receives an empty filename:current_vcpkg_baseline=$(jq -r '.configuration["default-registry"].baseline' "${manifest}")The neighboring
sedlines added in the same hunk already hard-code the manifest path./thirdparty/vcpkg/vcpkg.json.The bug stayed latent because the Bump vcpkg step only runs when
need_vcpkg_update == 'true'(i.e. a newer vcpkg release exists). The Jun 14 and Jun 21 scheduled runs passed only because the tag was unchanged and the step was skipped; the Jun 28 run was the first to actually execute the line after a new release appeared, so it failed.Fix
Use the same hard-coded manifest path the surrounding lines use.
Verified by dispatching the workflow on this branch: the run completed successfully and produced the (previously stuck) bump PR #6337.
Workflow-only change — no build platform is affected, so all
disable-build-*labels are applied.