macos-build-test must depend on prepare-image#6338
Merged
Conversation
generate-c-bindings needs prepare-image and produces the CBindings artifact the macOS job downloads. macos-build-test only needed config, so when prepare-image rebuilds images, macOS started early, burned ~30 min, then timed out the 1800s "Wait for C bindings" step because generate-c-bindings hadn't finished. Gate macOS on prepare-image like every other build-test job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
macos-build-testdeclaredneeds: [ config ]only, while every other build-test job (windows,ubuntu-x64,ubuntu-arm64,linux-vcpkg,emscripten,emscripten-c-bindings) gates on[ config, prepare-image ].The macOS job downloads the
CBindingsartifact produced bygenerate-c-bindings, which itselfneeds: [ config, prepare-image ]. So wheneverprepare-imageactually rebuilds the Docker images (e.g. a vcpkg/toolchain bump),generate-c-bindingsstarts late, but macOS does not wait forprepare-imageand starts immediately:Wait for C bindings, whosewait-for-jobhas a 1800 s (30 min) cap,generate-c-bindingsstill hasn't finished → the wait times out and the whole macOS matrix fails.Real failure: run 28315942681, macОС arm64/Debug —
Timed out after 1800s waiting for job "generate-c-bindings"after 31m22s of wasted runner time, across every macOS cell.Fix
Add
prepare-imagetomacos-build-test'sneeds, matching all the other build-test jobs. macOS now starts only after the images are ready, sogenerate-c-bindingsis already running in parallel by the time macOS reachesWait for C bindings, and the wait resolves normally instead of burning a runner for an hour and failing.CI note
Only the orchestration of the macOS job changes. Unaffected platforms are disabled via
disable-build-*labels.generate-c-bindingsand its image always run regardless (no disable condition), so the macOS → prepare-image → generate-c-bindings chain is still exercised.