[cryptotavares]

Summary: Fix the review comments on #62, #64 and #65 in one PR on top of the stack. The approved PRs stay unchanged.

Stack context: mm CLI v2, Phase 1, P1-43. Base: #69, the top of the stack.

Problem

Comment	Problem
#65: off-screen animations	The browser settle ignored animations whose target was outside the viewport or had zero size. A drawer sliding in, a bottom sheet or an accordion opening from height 0 start that way, so the observation caught them mid-move.
#64: late click	click / type checked the request signal only before the target wait. When the request timed out during the wait, the agent got "timed out", but the click still ran once the target appeared.
#64: batchTimeoutMs	batchTimeoutMs accepted up to 300 s, but the queue and the CLI stop run_steps after 30 s.
#62: refs after none	--observe none does not refresh refs; some refs can then click a different element. Not documented.
#62: reads and animations	Reads do not wait for animations, even with --observe full. Not documented.

Solution

flowchart TD
    A[click / type] --> B[Wait for target]
    B --> C{Request timed out?}
    C -->|yes| D[MM_REQUEST_ABORTED, no action]
    C -->|no| E[Click / tap / type]
    E --> F[Mutating observation]
    F --> G[Wait for every running finite animation, max 1 s]
    G --> H[Read tree]

    classDef new fill:#fff3cd,stroke:#d39e00
    class C,D,G new

Loading

Yellow boxes are new or changed.

What changes

Commit	Change
fix: wait for animations that start off screen or at zero size	animationsSettled waits for every running, finite animation of an element. Infinite animations are still ignored; the 1 s cap is unchanged.
fix: do not click or type after the request timed out	IPlatformDriver.click / type take an optional signal. Both drivers call signal.throwIfAborted() after the target wait, right before the action (mobile type also after the focus tap). The tools pass context.signal and return MM_REQUEST_ABORTED.
fix!: cap run_steps batchTimeoutMs at 30 s	Schema range 1000–30000, like the cdp timeoutMs.
docs: …	README, SKILL.md and CLI help: refs after --observe none, reads and animations, abort limits, batchTimeoutMs.

Decisions for reviewers

Decision	Reason
One new PR instead of changing #62/#64/#65	Pushing to an approved PR dismisses its approval, and the restack would change every PR above it.
An action that already started is not cancelled	@metamask/device-mcp takes no signal (waitForElement, tapElement, typeText), and Playwright's actionability checks are part of locator.click. The driver checks the signal between steps. Cancelling inside device-mcp needs a device-mcp change (follow-up).
Cap batchTimeoutMs at 30 s instead of raising the request budget for batches	Matches the CLI and queue default; long flows can be split into several batches.
Reads stay without the animation wait (docs only)	It is a less exact snapshot, not a wrong action. Can be revisited.
The 5 s testId collection cap stays	Agreed with the reviewer: watch real usage first.

Breaking changes

run_steps rejects batchTimeoutMs above 30000 (validation error), also when a server raised requestTimeoutMs.

Review guide

#	File	What to check
1	src/tools/utils/in-page.ts	animationsSettled without the viewport/size filter.
2	src/platform/playwright-driver.ts, src/platform/mobile-platform-driver.ts, src/platform/types.ts	throwIfAborted() placement.
3	src/tools/interaction.ts	Signal passed; abort mapped to MM_REQUEST_ABORTED.
4	src/validation/schemas.ts	batchTimeoutMs range and description.
5	README.md, SKILL.md, src/cli/mm.ts	Docs.

Testing

yarn test: 51 files, 1809 tests pass. yarn lint passes. Each commit passes the tests on its own.

Extension (e2e fixture wallet, headless), before = #69, after = this branch:

Check	Before	After
Drawer sliding in from off screen (400 ms): observationMs	515–516 (did not wait)	914–929 (waited)
Accordion from height 0 (400 ms): observationMs	515–516	916–917
Home click observationMs	513–514	512–515
Send / account list click observationMs	12–183 / 14–164	14–212 / 15–164
run_steps click whose target appears 1 s after the 30 s queue timeout	clicked	not clicked

Android (device-mcp 0.6.0, real funds, benign taps): all smoke and ref checks pass, same as #69.

iOS (device-mcp 0.6.0, real funds, benign taps): all smoke and ref checks pass, same as #69. (A first attempt hit the stale idb companion after a simulator reboot, dtuhidd connection ... invalidated; fixed by restarting the companion. See MetaMask/device-mcp#43 and #70.)