fix: run RPC fallback on Accounts API poll updates - #10078
Merged
Conversation
The stale-balance re-read only ran in the forced getAssets fast pipeline, so while the wallet sat open, 30s Accounts API polls kept committing responses that omit unindexed tokens with a plain merge — the stale amount survived until the next forced refresh (unlock, transaction, manual refresh). handleAssetsUpdate now inserts RpcFallbackMiddleware into the enrichment pipeline for AccountsApiDataSource updates, after graduation and before detection, mirroring the fast pipeline. WebSocket updates are excluded (incremental single-asset pushes — absence is not staleness) and RPC/Snap updates are excluded so RPC never re-triggers itself.
salimtb
force-pushed
the
fix/fix-polling-fallback
branch
from
September 2, 2026 16:19
831ee6b to
20944d2
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9ff47f3. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
@cursor fix the conflict |
|
I've successfully resolved the merge conflict in the Conflict Resolution:
Changes Made:
The PR now includes the latest changes from |
salimtb
enabled auto-merge
September 2, 2026 16:34
juanmigdr
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The stale-balance re-read only ran in the forced getAssets fast pipeline, so while the wallet sat open, 30s Accounts API polls kept committing responses that omit unindexed tokens with a plain merge — the stale amount survived until the next forced refresh (unlock, transaction, manual refresh).
handleAssetsUpdate now inserts RpcFallbackMiddleware into the enrichment pipeline for AccountsApiDataSource updates, after graduation and before detection, mirroring the fast pipeline. WebSocket updates are excluded (incremental single-asset pushes — absence is not staleness) and RPC/Snap updates are excluded so RPC never re-triggers itself.
Explanation
References
Checklist
Note
Medium Risk
Touches the live balance merge path for Accounts API polls and adds extra RPC reads when indexed tokens are omitted; scope is limited by source gating and existing fallback rules.
Overview
Fixes stale token balances that could persist while the wallet stayed open: periodic Accounts API polls merge responses that omit unindexed tokens, and
RpcFallbackMiddlewarepreviously ran only on the forcedgetAssetsfast path.handleAssetsUpdatenow runsRpcFallbackMiddlewareforAccountsApiDataSourceupdates in the enrichment pipeline (after custom-asset graduation, before detection), so tracked assets missing from a poll response are re-read on-chain via RPC. WebSocket (AccountActivityDataSource), RPC, and Snap updates are unchanged and do not trigger the fallback.Adds a unit test that asserts poll updates pass omitted tracked assets as
customAssetsto RPC, and that WebSocket updates do not invoke the fallback. Changelog updated under Fixed.Reviewed by Cursor Bugbot for commit ed7cf21. Bugbot is set up for automated code reviews on this repo. Configure here.