Skip to content

Release 1229.0.0 - #10080

Merged
adonesky1 merged 4 commits into
mainfrom
release/1229.0.0
Sep 2, 2026
Merged

Release 1229.0.0#10080
adonesky1 merged 4 commits into
mainfrom
release/1229.0.0

Conversation

@adonesky1

@adonesky1 adonesky1 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Explanation

Summary

Publish @metamask/phishing-controller 17.4.1 and @metamask/transaction-controller 69.8.0 so clients can pick up the address-poisoning known-set fix from #9943.

Problem

Phishing known recipients were hydrated via getEffectiveRecipient, which falls back to txParams.to for non-transfers. Confirmed approves and contract interactions therefore seeded token and protocol addresses into the comparison set, and vanity factories could 4+4-match each other (false positives on Permit2 approves).

Solution

  • @metamask/transaction-controller@69.8.0 (minor): export getSendRecipients for user-chosen send payees only
  • @metamask/phishing-controller@17.4.1 (patch): hydrate known recipients from getSendRecipients instead of getEffectiveRecipient, plus the pending C2 blocklist Set optimization and transaction-controller range bump to ^69.8.0

Workspace dependents bump their @metamask/phishing-controller / @metamask/transaction-controller ranges but are not published in this release.

Risk

No breaking API changes. Known-set membership narrows to real send payees (correct for poisoning). Clients still on older phishing-controller keep the old set until they bump.

Intentionally skipped

@metamask/address-book-controller, @metamask/base-controller, @metamask/controller-utils, @metamask/messenger, @metamask/accounts-controller, @metamask/approval-controller, @metamask/core-backend, @metamask/gas-fee-controller, @metamask/network-controller, @metamask/remote-feature-flag-controller, and @metamask/eth-block-tracker have unrelated unreleased changes and are not required for #9943.

@metamask/phishing-controller@17.4.1

Changed

  • Optimize C2 domain blocklist lookups by switching internal storage from Array to Set (#6388)
  • Bump @metamask/transaction-controller from ^69.5.2 to ^69.8.0

Fixed

  • Restrict address poisoning known recipients to user-chosen send payees (#9943)

@metamask/transaction-controller@69.8.0

Added

  • Export getSendRecipients (#9943)

Changed

  • Bump @metamask/utils from ^11.11.0 to ^11.12.0 (#10076)

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Release packaging and dependency alignment; behavioral fixes ship via already-reviewed controller versions with no additional logic in this PR.

Overview
Cuts monorepo release 1229.0.0 and publishes @metamask/phishing-controller@17.4.1 and @metamask/transaction-controller@69.8.0, with version/changelog/yarn.lock updates only (no new application source in this diff).

@metamask/transaction-controller@69.8.0 documents export of getSendRecipients so callers can resolve user-chosen send payees (simple sends, decoded transfers, swap-and-send, batch sends) without treating txParams.to as the payee.

@metamask/phishing-controller@17.4.1 documents switching address-poisoning “known recipient” hydration to getSendRecipients instead of getEffectiveRecipient, plus C2 blocklist storage moved from Array to Set for O(1) lookups.

Workspace packages that depend on phishing or transaction-controller bump to ^17.4.1 / ^69.8.0 (e.g. assets-controller, bridge, wallet); those packages are not newly published here—only the two security-related controllers and the root monorepo version.

Reviewed by Cursor Bugbot for commit 265147e. Bugbot is set up for automated code reviews on this repo. Configure here.

@adonesky1 adonesky1 added team-product-safety Push issues to Product Safety team release:keep-open Prevent auto-close of inactive release/* PRs (3h) labels Sep 2, 2026
@adonesky1
adonesky1 marked this pull request as ready for review September 2, 2026 20:25
@adonesky1
adonesky1 requested review from a team as code owners September 2, 2026 20:25
@metamask-ci

metamask-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ No changelog changes needed.

@mcmire mcmire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1
adonesky1 added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit 984bfda Sep 2, 2026
140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:keep-open Prevent auto-close of inactive release/* PRs (3h) team-product-safety Push issues to Product Safety team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants