Release 1229.0.0 - #10080
Merged
Merged
Conversation
adonesky1
marked this pull request as ready for review
September 2, 2026 20:25
adonesky1
temporarily deployed
to
default-branch
September 2, 2026 20:31 — with
GitHub Actions
Inactive
adonesky1
temporarily deployed
to
default-branch
September 2, 2026 20:31 — with
GitHub Actions
Inactive
|
✅ No changelog changes needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Summary
Publish
@metamask/phishing-controller17.4.1 and@metamask/transaction-controller69.8.0 so clients can pick up the address-poisoning known-set fix from #9943.Problem
Phishing known recipients were hydrated via
getEffectiveRecipient, which falls back totxParams.tofor non-transfers. Confirmed approves and contract interactions therefore seeded token and protocol addresses into the comparison set, and vanity factories could 4+4-match each other (false positives on Permit2 approves).Solution
@metamask/transaction-controller@69.8.0(minor): exportgetSendRecipientsfor user-chosen send payees only@metamask/phishing-controller@17.4.1(patch): hydrate known recipients fromgetSendRecipientsinstead ofgetEffectiveRecipient, plus the pending C2 blocklist Set optimization and transaction-controller range bump to^69.8.0Workspace dependents bump their
@metamask/phishing-controller/@metamask/transaction-controllerranges but are not published in this release.Risk
No breaking API changes. Known-set membership narrows to real send payees (correct for poisoning). Clients still on older phishing-controller keep the old set until they bump.
Intentionally skipped
@metamask/address-book-controller,@metamask/base-controller,@metamask/controller-utils,@metamask/messenger,@metamask/accounts-controller,@metamask/approval-controller,@metamask/core-backend,@metamask/gas-fee-controller,@metamask/network-controller,@metamask/remote-feature-flag-controller, and@metamask/eth-block-trackerhave unrelated unreleased changes and are not required for #9943.@metamask/phishing-controller@17.4.1Changed
ArraytoSet(#6388)@metamask/transaction-controllerfrom^69.5.2to^69.8.0Fixed
@metamask/transaction-controller@69.8.0Added
getSendRecipients(#9943)Changed
@metamask/utilsfrom^11.11.0to^11.12.0(#10076)References
Checklist
Note
Low Risk
Release packaging and dependency alignment; behavioral fixes ship via already-reviewed controller versions with no additional logic in this PR.
Overview
Cuts monorepo release 1229.0.0 and publishes
@metamask/phishing-controller@17.4.1and@metamask/transaction-controller@69.8.0, with version/changelog/yarn.lockupdates only (no new application source in this diff).@metamask/transaction-controller@69.8.0documents export ofgetSendRecipientsso callers can resolve user-chosen send payees (simple sends, decoded transfers, swap-and-send, batch sends) without treatingtxParams.toas the payee.@metamask/phishing-controller@17.4.1documents switching address-poisoning “known recipient” hydration togetSendRecipientsinstead ofgetEffectiveRecipient, plus C2 blocklist storage moved fromArraytoSetfor O(1) lookups.Workspace packages that depend on phishing or transaction-controller bump to
^17.4.1/^69.8.0(e.g.assets-controller, bridge, wallet); those packages are not newly published here—only the two security-related controllers and the root monorepo version.Reviewed by Cursor Bugbot for commit 265147e. Bugbot is set up for automated code reviews on this repo. Configure here.