fix(stellar-wallet-snap): txn history with empty account - #255
Open
stanleyyconsensys wants to merge 4 commits into
Open
fix(stellar-wallet-snap): txn history with empty account#255stanleyyconsensys wants to merge 4 commits into
stanleyyconsensys wants to merge 4 commits into
Conversation
stanleyyconsensys
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
parseContractEventsFromResultMeta contains a confirmed switch fallthrough bug that breaks V3 meta parsing and can cause valid contract events to be dropped.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR improves @metamask/stellar-wallet-snap transaction history mapping for Soroban invoke-host-function transactions by detecting wallet-credited SAC transfer contract events in result_meta_xdr, allowing these credits (native and classic CODE:ISSUER) to be surfaced as Receive transactions rather than Unknown.
Changes:
- Add generic parsing utilities to walk contract events from Horizon
result_meta_xdrand safely parse SACtransferevents credited to a given account. - Extend
TransactionMapperto map eligible invoke-host-function transactions as receives based on parsed contract events (native + classic assets). - Add fixtures and unit tests covering receive mapping for contract swap credits; update the package changelog.
File summaries
| File | Description |
|---|---|
| packages/stellar-wallet-snap/src/services/transaction/xdrParser.ts | Adds contract-event extraction from result_meta_xdr and a safe SAC transfer parser for receive detection. |
| packages/stellar-wallet-snap/src/services/transaction/xdrParser.test.ts | Adds unit tests for parsing credited SAC transfers from transaction meta. |
| packages/stellar-wallet-snap/src/services/transaction/TransactionMapper.ts | Adds invoke-host-function receive fallback mapping driven by meta contract events. |
| packages/stellar-wallet-snap/src/services/transaction/TransactionMapper.test.ts | Adds mapping coverage for native + USDC contract-swap receive scenarios. |
| packages/stellar-wallet-snap/src/services/transaction/mocks/horizon-transaction-responses.fixtures.ts | Introduces Horizon fixtures containing result_meta_xdr with SAC transfer events. |
| packages/stellar-wallet-snap/CHANGELOG.md | Adds an Unreleased “Fixed” entry describing the improved receive mapping. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+404
to
+406
| describe('parseContractEventsFromResultMeta', () => { | ||
| it('accumulates native SAC transfers credited to the wallet', () => { | ||
| const results = parseContractEventsFromResultMeta({ |
Contributor
Author
There was a problem hiding this comment.
we cover it via fixture already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR improves @metamask/stellar-wallet-snap transaction history mapping for Soroban invoke-host-function transactions by detecting wallet-credited SAC transfer contract events in result_meta_xdr, allowing these credits (native and classic CODE:ISSUER) to be surfaced as Receive transactions rather than Unknown.
Changes:
References
Checklist