feat: support creating Snaps and libraries with create-package - #258
Draft
ulissesferreira wants to merge 1 commit into
Draft
Conversation
- Require a `--type` option (`snap` or `library`, shorthand `lib`) when creating a new package; there is no default. - Add a snap template, migrated from the now-removed `sample-snap` package. - Rename `package-template` to `library-template` and sync its configs with `snap-networks-utils`. - Drop the obsolete root tsconfig reference updates, since the root configs no longer track package references.
ulissesferreira
changed the title
create-package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on #257.
Refactors
create-packageso it can scaffold both Snaps and non-Snap library packages, and removes thesample-snappackage now that a Snap can be generated from a template.--typeoption (no default):snap,library, or thelibshorthand.snap-templatebased onsample-snap, and deletepackages/sample-snap.package-templatetolibrary-templateand sync itstsconfig/jestconfigs and dependency versions withsnap-networks-utils.tsconfigreference updates, which are obsolete now that the root configs no longer track package references.docs/processes/adding-new-packages.mdandAGENTS.mdaccordingly.Verified end to end: generated a library and a snap with the new CLI, then type-checked, built, and tested both.