Repository navigation
fix(auth): only accept PPA certificates from trusted issuers - #1174
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PP-Auth's accreditation link (link 6 of
verifyDeploymentChain) verified the certificate againstevidence.issuerJwksUri. That key-set URL is supplied by the deployment being checked, so any deployment could host its own JWKS, sign itself a certificate at any level for any domains, and pass the chain.Fix
Only certificates from trusted certifying authorities count:
ChainOptions.trustedPpaIssuers(hosts or origins) defaults toDEFAULT_TRUSTED_PPA_ISSUERS = ["https://ppa.w3ds.metastate.foundation"].issmust be on the list. This is checked before any key is fetched, so the evidence can't steer the verifier to a key set of its choosing.<issuer>/.well-known/jwks.json, never fromevidence.issuerJwksUri, andjwtVerifyalso enforcesiss.normalizePpaIssuersandppaJwksUriare exported for other verifiers.iss, like the real PPA's (setIssuer(publicUrl())).PP_AUTH_TRUSTED_PPA_ISSUERS(comma-separated) so a local PPA can be trusted during development. Unset keeps the default.Tests
packages/authpasses 62/62, andtsc --noEmitis clean. New cases:issuerJwksUripointing at the attacker's key set, is refused.normalizePpaIssuershandles bare hosts, trailing slashes, http for dev, and junk entries.GitW3 applies the same rule to the PPA decisions it reads from platform eVaults.