Repository navigation
feat(w3ds-oidc-connector): carry the eName and the eVault profile's email through any IdP - #1179
Merged
Merged
Conversation
…s standard claims so they survive any IdP
… and the unverified profile email
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Testing Nextcloud → Rauthy → W3DS OIDC connector left Nextcloud with a 64-character hex user ID and no link to the eName. The cause isn't Rauthy-specific: every IdP between the connector and an app issues its own
sub, so the eName stops at the IdP. Nextcloud'suser_oidcthen hashes that IdPsubinto the user ID.This makes the connector IdP-agnostic by relying only on standard OIDC claims:
sub, and alsopreferred_username(the eName without@; lossless because eNames are UUIDs). IdPs passpreferred_usernameon to their own apps, so it is the documented carrier of the eName behind any IdP.User, falling back toProfessionalProfile) and sent asemail,name,given_nameandfamily_name.email_verifiedis alwaysfalse: the profile is self-asserted. The docs warn against linking accounts by email. For example, Rauthy's Auto-Link ignoresemail_verified, so turning it on would allow account takeover.emailscope. The portal's "requires an email" setting is kept as a compat override: it always sends an email, falling back to the@w3ds.invalidplaceholder.user_oidcsettings (--unique-uid=0 --mapping-uid=preferred_username). Provider guides and the portal page are updated.The Nextcloud side (a one-scan wallet confirmation for OIDC users) ships in ensombl/nextcloud-w3ds-login.
Testing
w3ds-oidc-connector: 196/196 pass.tsc --noEmitis clean. New coverage:{}/userinfocarrying the profile claims