Repository navigation
Conversation
Add a public GET /api/apps to the marketplace that returns the curated apps.json list plus live AaaS platforms. The wallet's apps ribbon now fetches it and keeps the bundled list if the marketplace can't be reached.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy note: deploy the marketplace before releasing the wallet. Until
/api/appsis live, the wallet keeps showing its bundled list, so the wrong order doesn't break anything.What
The apps ribbon on the eID wallet's main screen had five apps hard-coded. It now loads the list from the marketplace, so apps added to the marketplace (curated or published through AaaS) show up in the wallet without a new release.
GET /api/apps. Returns the curatedapps.jsonlist plus the live AaaS platforms. When an app is in both, the curated entry wins, which is the same rule the home page uses. If AaaS fails, the curated list is still returned. The response is public (Access-Control-Allow-Origin: *) and cached for 5 minutes.Design decisions
httpslinks and logos. Apps without a web link, like the wallet's own entry, are skipped./charter.pngare resolved against the marketplace host. If there is no logo or it fails to load, the card shows the app's first letter.Known gaps
/api/appsin a follow-up.Testing
npm test -- src/lib/utils/passes 39/39, including 5 new tests formarketplaceApps(mapping, bundled-logo preference, rejecting non-https links and logos, duplicates, malformed payloads, non-2xx responses).svelte-checkreports 0 errors, and biome is clean on the changed files.tscshows no new errors; the only error (missingdotenvtypes) was already there. CallinglistCatalogApps()with no AaaS key returns the 12 curated apps./api/appson a running marketplace with AaaS configured.