Repository navigation
chore(eid-wallet): bump to 1.3.0 - #1189
Conversation
The apps ribbon now loads from the marketplace's live platforms (#1181), a new user-facing capability, so this is a minor rather than a patch. #1188 follows with the category translations. The Android versionCode goes to 33, continuing 24, 25, 26, 27, 28, 31, 32. .env.example gains the docs site as a commented value for PUBLIC_TRANSLATIONS_URL, the way it already offers the registry and provisioner URLs per environment. Empty disables the runtime correction catalog, which suits a local checkout but leaves a release build unable to receive wording fixes.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe changes update translation URL comments in ChangesTranslation URL Documentation
eID Wallet Version Metadata
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The wallet’s release metadata is aligned across platforms, and the translation guidance matches the catalog generation and fallback behavior. No actionable merge-blocking risk remains. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The changes do not themselves enable remote translations or weaken existing controls. However, following the release guidance would let the configured catalog supply wallet wording. The actual release configuration and publisher controls remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Biome (2.5.13)infrastructure/eid-wallet/package.jsonBiome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins. infrastructure/eid-wallet/src-tauri/tauri.conf.jsonBiome could not lint this file: configuration resulted in errors. Check the repository's Biome configuration and plugins. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Description of change
Bumps the eID wallet from 1.2.0 to 1.3.0 ahead of the release.
Minor rather than patch: #1181 replaced the five hard-coded apps in the ribbon with the marketplace's live platforms, which is a new user-facing capability and the headline of this release. #1188 follows with labels for the categories those platforms actually publish.
Whoever builds the release must set
PUBLIC_TRANSLATIONS_URL. Left empty, the wallet ignores the runtime correction catalog, so the ru/uk category wording #1188 describes as "correctable later without a release" cannot actually be corrected. It has been empty since the mechanism landed in #1145, so no shipped build has ever had it on. This PR only documents the value; setting it is a build-time step.Design decisions
The Android
versionCodeis a hand-maintained counter intauri.conf.json, not derived from the version string, and Play rejects an upload that does not raise it. It goes to 33, continuing 24, 25, 26, 27, 28, 31, 32.The version string is written in seven places —
tauri.conf.json,package.json,Cargo.toml,Cargo.lock, and the three generated iOS files.project.pbxprojis the one that matters for the iOS build: #1168 initially missed it, which would have shipped iOS at the old version..env.examplekeeps the empty default and offers the docs site as a commented alternative, matching how it already lists the registry and provisioner URLs per environment.Type of change
How the change has been tested
pnpm buildininfrastructure/eid-wallet, with the catalog URL set locally: the bundle carries1.3.0on the settings node and the URL in_app/env.js. No code paths touched otherwise.The catalog itself is live:
https://docs.w3ds.metastate.foundation/translations.jsonreturns 200 withaccess-control-allow-origin: *and an ETag, and already contains the nine category keys from #1188.Note for anyone building from a stale checkout:
pnpm installis required first, or Rollup fails to resolve@tauri-apps/plugin-http, the dependency #1181 added.Change checklist
Summary by CodeRabbit