Repository navigation
feat(evault): eVault manifests and vault type in /whois - #1190
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
33fe224 to
8661c35
Compare
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8661c356c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 333066601d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description of change
Adds eVault manifests:
/whoisnow returns the vault'stype(user|group|company) and itsmanifest, the record describing who the vault belongs to, nested in full.company; keyless vault with a Chat/GroupManifest naming it →group; otherwiseuser.ename/eNameis the vault. Pinned lazily on first/whoison the vault's Neo4jUsernode, immutable once set, re-resolved if the record is deleted.…440003(shared with Chat; only records withmembers+owner), legacya8bfb7cf-…as fallback.adminIdsare resolved to eNames.User.eNamebecomes a unique constraint (duplicates merged first) so the pin lock holds under concurrentMERGE./whoisserves the manifest regardless of its ACL; GraphQL access is unchanged.company.jsonextended with profile fields;groupManifestEnvelopeIdis now optional.Issue Number
Type of change
How the change has been tested
manifest.service.spec.ts(13 tests, Neo4j testcontainer): keyed/keyless users, earliest self-naming pick, stable pin, unknown eName writes nothing, existing GroupManifest, Chat not mistaken for a manifest, legacy fallback, Chat-only group withadminIds, 5 concurrent lookups → one GroupManifest, Company beats an earlier GroupManifest, deleted pin re-resolves, duplicateUsernodes merged by the migration.db.service.spec.tsandsrc/core/aclstill pass;tsc --noEmitclean.Change checklist