Skip to content

feat(evault): eVault manifests and vault type in /whois - #1190

Merged
coodos merged 3 commits into
mainfrom
feat/evault-manifests
Oct 7, 2026
Merged

coodos merged 3 commits into
mainfrom
feat/evault-manifests

Conversation

@coodos

@coodos coodos commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Description of change

Adds eVault manifests: /whois now returns the vault's type (user | group | company) and its manifest, the record describing who the vault belongs to, nested in full.

  • Type is inferred: Company record naming the vault → company; keyless vault with a Chat/GroupManifest naming it → group; otherwise user.
  • Manifest is the earliest record of that type's ontology (UserProfile, GroupManifest, Company) whose ename/eName is the vault. Pinned lazily on first /whois on the vault's Neo4j User node, immutable once set, re-resolved if the record is deleted.
  • Group manifests are read from …440003 (shared with Chat; only records with members + owner), legacy a8bfb7cf-… as fallback.
  • Old groups with only a Chat get a GroupManifest built from it once; adminIds are resolved to eNames.
  • User.eName becomes a unique constraint (duplicates merged first) so the pin lock holds under concurrent MERGE.
  • /whois serves the manifest regardless of its ACL; GraphQL access is unchanged.
  • company.json extended with profile fields; groupManifestEnvelopeId is now optional.
  • Type and manifest are copied on eVault migration.

Issue Number

Type of change

  • New (a change which implements a new feature)

How the change has been tested

manifest.service.spec.ts (13 tests, Neo4j testcontainer): keyed/keyless users, earliest self-naming pick, stable pin, unknown eName writes nothing, existing GroupManifest, Chat not mistaken for a manifest, legacy fallback, Chat-only group with adminIds, 5 concurrent lookups → one GroupManifest, Company beats an earlier GroupManifest, deleted pin re-resolves, duplicate User nodes merged by the migration. db.service.spec.ts and src/core/acl still pass; tsc --noEmit clean.

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 76657c74-e986-4395-93eb-9ac7f80a57fa
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coodos
coodos force-pushed the feat/evault-manifests branch from 33fe224 to 8661c35 Compare October 7, 2026 11:04
@coodos

coodos commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create a Codex account and connect to github.

@coodos

coodos commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8661c356c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread infrastructure/evault-core/src/core/manifest/manifest.service.ts Outdated
Comment thread infrastructure/evault-core/src/core/db/db.service.ts
Comment thread infrastructure/evault-core/src/core/manifest/manifest.service.ts Outdated
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-07T11:47:39.569294Z 3330666 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 333066601d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread infrastructure/evault-core/src/index.ts
Comment thread infrastructure/evault-core/src/core/manifest/manifest.service.ts
Comment thread infrastructure/evault-core/src/core/manifest/manifest.service.ts
Comment thread infrastructure/evault-core/src/core/manifest/manifest.service.ts
Comment thread infrastructure/evault-core/src/core/manifest/manifest.service.ts
@coodos
coodos merged commit ed9d386 into main Oct 7, 2026
7 checks passed
@coodos
coodos deleted the feat/evault-manifests branch October 7, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant