Repository navigation
feat(ontology): company directors, roles, delegations, delegated signatures and shareholdings - #1191
Conversation
…atures and shareholdings
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 924afdc2a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1179977242
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…mes and stale revocation reasons
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e515484d30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Description of change
PR 1 of 6 for company signing delegation: the schemas. Directors hand out titled Roles; a Delegation lets a person sign for the company within the role's scopes.
company.json:directors[](any one director has root power; only a director changes the list) andauthorization.role.json(65fd0e21-…): title,scopes[],appLimits,mayRedelegate, validity window, status.delegation.json(0b2f15d8-…): assigns a Role (roleId) or narrows a parent (parentDelegationId), exactly one;revocationReason: cascadefor explicit cascades.delegatedSignature.json(e2736a06-…): audit record written to the company eVault by the verifying platform.shareholding.json(6382a144-…): record only, no authority.ontology:<schemaId>or@<platform-eName>:<keyword>.authorization: the grantor's wallet signature over the record (w3ds-grant/v1), verified by the eVault in PR 3.Next:
packages/delegation(payload format, narrowing, core-scope denylist, chain evaluation), eVault write guard, verifier/SDK, wallet, admin app.Issue Number
Type of change
How the change has been tested
All five schemas compiled with Ajv 8 + formats against 10 sample records (valid role/delegation/signature/shareholding/company; rejected bad scope, both/neither of
roleId/parentDelegationId, holder-less shareholding). Ontology service boots with 68 schemas and serves each new id.Change checklist