Repository navigation
feat(examples): company delegation demo on real eVaults with in-process wallets - #1196
Conversation
|
@codex review |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84d76c98fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ed Bob after he is revoked
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f812aa9a27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… a verified view of Acme
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0606d2ba6c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d34c7f506
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…with hop-by-hop verifier traces
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a9352da18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b6705848b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Description of change
PR 5 of 5 for company signing delegation: a one-page demonstrator, no editor. Everything is real on the local
pnpm dev:corestack: eVaults provisioned per person with wallet-sdk wallets running in-process (P-256 keys, keys bound via/public-key), a keyless company eVault, realw3ds://signrequests that the demo wallet signs and POSTs to a localhost callback, andverifyDelegatedSignaturereading the company eVault's history.examples/company-delegation-demo(+examples/*workspace glob): Express on :5180. The page is a slide story with SVG stick figures (cast, Acme is born, titles handed down, then one act per scenario, curtain recap); each slide runs its step for real. Raw records on/dashboard.html. Setup fromdemo.config.json, generated state in gitignored.demo/state.json.pnpm --filter company-delegation-demo smokeruns setup plus all six headless and fails on any surprise.fix(evault)):ManifestServiceusedEXISTSsubqueries insideRETURNand comparedEXISTSresults with=. Neo4j 5 (the testcontainers) accepts both; Neo4j 4.4 (docker-compose.databases.yml) does not, so/whoisreturnedtype: nullfor every vault locally. Rewritten as countedOPTIONAL MATCHes and plain booleanEXISTSpredicates.Issue Number
Type of change
How the change has been tested
pnpm dev:corelocally (Neo4j 4.4), thenpnpm --filter company-delegation-demo smoke: setup ✓ and all six scenarios end as expected (valid / not_covered / valid / reserved_payload / chain_invalid NOT_FOUND / chain_invalid REVOKED ×2). Page driven by hand at http://localhost:5180. Manifest tests still 13/13 on Neo4j 5.tsc --noEmitclean;pnpm install --frozen-lockfilepasses with only the new importer added.Change checklist