Repository navigation
fix: dual chat init dreamsync - #372
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces a DM ID-based guard in group webhook processing to skip DM-derived groups and marks webhooks completed. Updates chat/group description strings to embed a “DM ID: {userId}::{dreamsyncUser.id}” pattern during mutual chat creation. No public API/signature changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant W as Webhook Source
participant S as Subscriber (sendGroupWebhook)
participant C as WebhookController
participant L as Logger
W->>S: Group event
S->>S: Check description prefix
alt Description starts with "DM ID:" (new)
S->>L: Log skip: DM-derived group
S-->>W: Return (no webhook dispatched)
else not DM-derived
S->>C: Dispatch webhook
C->>C: Validate group
alt Description starts with "DM ID:" (new)
C->>L: Log skip and mark completed
C-->>S: 200 OK (early exit)
else Other existing guards / normal flow
C->>C: Continue processing
C-->>S: Response
end
end
note over S,C: New DM ID guards parallel existing "Match ID" checks
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit