Skip to content

fix: zooming-on-ios - #411

Merged
coodos merged 1 commit into
mainfrom
fix/zooming-on-ios
Nov 12, 2025
Merged

coodos merged 1 commit into
mainfrom
fix/zooming-on-ios

Conversation

@grv-saini-20

@grv-saini-20 grv-saini-20 commented Nov 12, 2025 •

Copy link
Copy Markdown
Collaborator

Description of change

Prevent screen from zoom in and zoom out.

Issue Number

closes #407

Type of change

  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)

How the change has been tested

CI and Manual

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Mobile Experience
    • Disabled zoom functionality on mobile devices to prevent unintended zoom interactions.

@grv-saini-20 grv-saini-20 self-assigned this Nov 12, 2025
@grv-saini-20
grv-saini-20 requested a review from coodos as a code owner November 12, 2025 05:02
@coderabbitai

coderabbitai Bot commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

The viewport meta tag in the HTML entry point was updated to prevent mobile zooming by adding maximum-scale=1.0 and user-scalable=no parameters, restricting zoom functionality.

Changes

Cohort / File(s) Change Summary
Viewport Configuration
infrastructure/eid-wallet/src/app.html
Updated viewport meta tag with maximum-scale=1.0 and user-scalable=no to disable mobile zoom

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 No pinch, no zoom, the viewport stays tight,
A scaled-down world on mobile's bright light,
Fixed and frozen, just right and neat,
The rabbit hops to make UX complete! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is entirely a template with no specific details filled in: no issue number, no selected type of change, no testing information, and no completed checklist items. Fill in all required sections: add the issue number, select 'Fix' as the type of change, describe how the change was tested, and complete the checklist by checking off applicable items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: zooming-on-ios' is concise and clearly identifies the main change — preventing zooming on iOS by updating the viewport meta tag.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/zooming-on-ios

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f50f506 and dee7923.

📒 Files selected for processing (1)
  • infrastructure/eid-wallet/src/app.html (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: lint

Comment thread infrastructure/eid-wallet/src/app.html
@coodos
coodos merged commit 0198358 into main Nov 12, 2025
3 checks passed
@coodos
coodos deleted the fix/zooming-on-ios branch November 12, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Screen Zoom in and Zoom out in eid wallet

3 participants