Skip to content

fix: WYSIWYG toolbar doesn't follow scroll on private notes#4600

Merged
SylvainChevalier merged 3 commits into
mainfrom
claude/issue-4261-wysiwyg-toolbar-doesnt-follow-scroll
May 19, 2026
Merged

fix: WYSIWYG toolbar doesn't follow scroll on private notes#4600
SylvainChevalier merged 3 commits into
mainfrom
claude/issue-4261-wysiwyg-toolbar-doesnt-follow-scroll

Conversation

@SylvainChevalier
Copy link
Copy Markdown
Contributor

@SylvainChevalier SylvainChevalier commented Apr 8, 2026

Use overflow-x-clip instead of overflow-x-hidden in QuestionSection to fix sticky toolbar in private notes.

overflow-x-hidden implicitly creates overflow-y:auto per CSS spec, which forms a scroll container that breaks position:sticky on the WYSIWYG toolbar. overflow-x-clip clips horizontal overflow without creating a scroll container.

Fixes #4261

Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Improved horizontal overflow handling on the question detail page for better content display.

Review Change Stack

…oolbar in private notes

overflow-x-hidden implicitly creates overflow-y:auto per CSS spec, which forms
a scroll container that breaks position:sticky on the WYSIWYG toolbar.
overflow-x-clip clips horizontal overflow without creating a scroll container,
so the toolbar correctly follows viewport scroll.

Fixes #4261

Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6f4a9012-bedd-44a0-b495-91a4cd7fcca4

📥 Commits

Reviewing files that changed from the base of the PR and between a75665e and 2cf4d0f.

📒 Files selected for processing (1)
  • front_end/src/app/(main)/questions/[id]/components/question_layout/question_section.tsx

📝 Walkthrough

Walkthrough

A single CSS class change on the question section's root container updates horizontal overflow behavior from overflow-x-hidden to overflow-x-clip, adjusting how overflow content is clipped on the x-axis.

Changes

Overflow Behavior Fix

Layer / File(s) Summary
Overflow behavior adjustment
front_end/src/app/(main)/questions/[id]/components/question_layout/question_section.tsx
Root section container switches overflow-x-hidden to overflow-x-clip to modify x-axis overflow clipping behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • ncarazon
  • cemreinanc

Poem

🐰 A scroll, a clip, a tiny fix,
Where overflow rules mix and twist,
One class swapped for another's call,
Now toolbars follow, after all! ✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main fix: addressing the WYSIWYG toolbar sticky positioning issue on private notes.
Linked Issues check ✅ Passed The PR directly addresses issue #4261 by implementing the CSS change to replace overflow-x-hidden with overflow-x-clip, which prevents creation of a scroll container that breaks position:sticky on the toolbar.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to fix the specific issue: only the overflow property in QuestionSection is modified to resolve the toolbar sticky positioning problem.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-4261-wysiwyg-toolbar-doesnt-follow-scroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Cleanup: Preview Environment Removed

The preview environment for this PR has been destroyed.

Resource Status
🌐 Preview App Deleted
🗄️ PostgreSQL Branch Deleted
⚡ Redis Database Deleted
🔧 GitHub Deployments Removed
📦 Docker Image Retained (auto-cleanup via GHCR policies)

Cleanup triggered by PR close at 2026-05-19T15:42:59Z

@SylvainChevalier
Copy link
Copy Markdown
Contributor Author

lgtm.

@SylvainChevalier SylvainChevalier marked this pull request as ready for review May 18, 2026 16:59
@SylvainChevalier SylvainChevalier requested a review from ncarazon May 18, 2026 16:59
@SylvainChevalier SylvainChevalier merged commit a18ad6e into main May 19, 2026
15 checks passed
@SylvainChevalier SylvainChevalier deleted the claude/issue-4261-wysiwyg-toolbar-doesnt-follow-scroll branch May 19, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wysiwyg toolbar doesn't follow scroll on long private notes

2 participants