fix: only show unlisted project chip when it's the main project#4690
fix: only show unlisted project chip when it's the main project#4690SylvainChevalier wants to merge 1 commit into
Conversation
Closes #4687 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe sidebar component now filters project chips based on visibility. ChangesProject Visibility Filtering in Sidebar
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
|
@claude the unlisted project chips are still visible even when they're not the default project. |
|
Claude finished @SylvainChevalier's task in 7m 6s —— View job Investigation
AnalysisThe filter at .filter(
(project) =>
!("visibility" in project) ||
project.visibility !== ProjectVisibility.Unlisted ||
project.id === defaultProjectId
);Equivalent to: filter OUT a project when Before I push a code change, I want to make sure I understand what you're seeing — could you confirm one of these for me:
If you can paste the URL of a question where you observe the bug (and ideally which chip is still showing), I can dig into the specific data and push a targeted fix. |
|
Well, looks good now. |
Closes #4687
Summary
Hides unlisted project chips in the question page sidebar when the unlisted project is a secondary project. Unlisted projects are still shown when they are the question's main (default) project.
Implementation
Added a filter in
sidebar_question_projects.tsxthat drops any project withvisibility === ProjectVisibility.Unlistedunless itsidmatchesdefault_project.id.Generated with Claude Code
Summary by CodeRabbit