fix: restore cursor date label on binary/discrete chart mouseover#4740
Draft
SylvainChevalier wants to merge 1 commit into
Draft
fix: restore cursor date label on binary/discrete chart mouseover#4740SylvainChevalier wants to merge 1 commit into
SylvainChevalier wants to merge 1 commit into
Conversation
VictoryPortal's useEffect dep `[props.children]` doesn't re-run when VictoryCursorContainer clones the portal with new cursor props each mouse move, so the portal kept rendering the frozen initial label (empty text at defaultCursor) instead of updating with the hover date. Unwrap ChartCursorLabel from VictoryPortal in numeric_chart.tsx and group_chart.tsx, matching multiple_choice_chart.tsx which never had the wrapper and was unaffected. Fixes #4737 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
SylvainChevalier
had a problem deploying
to
Preview
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4737
Root cause
VictoryPortal'suseEffecthas dependency[props.children]. WhenVictoryCursorContainerre-clones the portal element on each mouse move, it preserves the same children reference, so the effect never re-runs and the portal keeps rendering the stale initial cursor label (empty text atdefaultCursor).Fix
Unwrap
ChartCursorLabelfromVictoryPortalinnumeric_chart.tsxandgroup_chart.tsx, matching the working pattern inmultiple_choice_chart.tsxwhich was unaffected by the bug.Test plan
Generated with Claude Code