Rename project date fields: close_date → winners_announced_date, forecasting_end_date → close_date#4741
Draft
SylvainChevalier wants to merge 1 commit into
Draft
Conversation
…ecasting_end_date -> close_date The previous naming was confusing because the field labelled "Closes" on the front end was named `forecasting_end_date` in the backend, while `close_date` actually referred to the wrap-up / prize payout date displayed as "Winners announced date". This commit aligns the backend with the user-facing language: - close_date (deadline / prizes paid) -> winners_announced_date - forecasting_end_date (last scored question close) -> close_date - Improved help_text on both fields - Renamed move_project_forecasting_end_date -> move_project_close_date - Updated all backend references, frontend types/components, mock data, and i18n placeholder name (English copy fully updated; other locales updated to use the new placeholder so they remain functional pending translation refresh). Includes migration 0024 that swaps the two columns via a temporary name. Refs #4394 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
SylvainChevalier
had a problem deploying
to
testing_env
GitHub Actions
Failure
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
Contributor
|
This needs to be carefully reviewed & tested. Also, we should keep old field ref in serializers for backward compatibility in case someone is using our projects API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4394.
Summary
Align backend naming with user-facing labels:
close_date(deadline / prizes paid) →winners_announced_dateforecasting_end_date(last scored question close) →close_datehelp_texton both fields per @skmmcj's wordingmove_project_forecasting_end_date→move_project_close_date0024swaps the two columns via a temporary nameTest plan
manage.py migrateapplies cleanly on a fresh DB and on a DB migrated up to0023winners_announced_date)Generated with Claude Code