Skip to content

Implement ComparisonShare serving and sharing URLs for property comparison #1292

Description

@nanaf6203-bit

Context

schema.prisma has ComparisonShare (shareable comparison links with token/expiry) created by property-comparison.service.ts; ComparisonShare is otherwise unexposed.

Problem

The data model and generation logic exist but there is no read/share endpoint: shared links can't be loaded or expire; the model is effectively dead outside of property-comparison creation tests, contradicting the module's purpose to let users share comparisons.

Proposed approach

Add GET /property-comparison/shares/:token returning the two compared properties (public, without owner PII), enforce expiresAt/revokedAt, and track share views; add e2e for valid/expired/revoked tokens.

Acceptance criteria

  • Shared links resolve correctly and expire; coverage added.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions