fix(i18n,email): request-aware validation i18n, bounce suppression, C… - #1314
Merged
nanaf6203-bit merged 2 commits intoSep 25, 2026
Merged
Conversation
…onfigService unsubscribe
|
@fadee26 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
nanaf6203-bit
requested changes
Sep 25, 2026
nanaf6203-bit
left a comment
Contributor
There was a problem hiding this comment.
@fadee26 please resolve conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1237
Closes #1234
Closes #1233
Closes #1232
#1237 – I18nService failure/fallback coverage
warn, missing files, dual-load failure.q=0, wildcard*, equal-q ordering.q=0and pure*tags.#1234 – ValidationPipe uses request language
src/common/request-language.store.ts(AsyncLocalStorage).main.tsstoresAccept-Language/x-language/user.languagePreference.exceptionFactoryreads the store and passesacceptLanguageHeader+userPreferenceintoi18n.translate(no longer hard-codedundefined).#1233 – Bounce-aware send suppression
shouldSuppressAddress()counts recentHARDbounces andCOMPLAINEDevents (90-day window, threshold 1).sendEmailskips queueing when suppressed; also skipsemailStatus === 'BOUNCED'.#1232 – Unsubscribe URL from ConfigService
const UNSUBSCRIBE_URL = process.env.FRONTEND_URL ….buildListUnsubscribeHeaderreadsFRONTEND_URLviaConfigServiceat call time and usesbuildUnsubscribeUrl.Test plan