Skip to content

contracts/hello-world is a Soroban (soroban-sdk) contract inside the ink! workspace, contradicting its own deprecation doc #1204

Description

@nanaf6203-bit

Context: contracts/hello-world/src/lib.rs uses soroban_sdk::{contract, contractimpl, ...} (Stellar SDK) while the workspace Cargo.toml lists it under members with a # Added this comment and workspace deps include soroban-sdk 22.0.10. docs/hello_world_deprecation.md declares hello-world marked for removal.

Problem: A deprecated Stellar contract ships in a Substrate/ink! repository, pulling an unrelated SDK into workspace resolution; its # Added this comment conflicts with the deprecation plan, and smoke-ci/clippy runs over --all-targets --all-features would build it with the wrong toolchain for the repo's audit tooling.

Proposed approach: Execute the deprecation: remove the member (and the soroban-sdk workspace dep) or move it to a separate workspace/stacc; keep the deprecation note as a PR description for the removal.

Acceptance criteria: hello-world (or soroban dep) removed from workspace; cargo metadata no longer resolves soroban-sdk; docs updated.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions