Skip to content

Pre-commit still runs cargo contract build despite ISSUES_RESOLUTION.md switching the hook to cargo check #1206

Description

@nanaf6203-bit

Context: ISSUES_RESOLUTION.md records resolving the slow cargo contract build pre-commit hook by replacing it with cargo check, but .pre-commit-config.yaml still contains both a cargo-check hook AND a cargo-contract-build hook (under Contract-specific checks).

Problem: The resolved issue is contradicted by the config: every contracts change still triggers the slow wasm build locally, and the two hooks duplicate checking with different tools, making pre-commit runs slow and confusing.

Proposed approach: Keep cargo check (fast, correct for ink! prototyping), delete the cargo-contract-build hook, and re-record the resolution; verify unchanged behavior via pre-commit run --all-files.

Acceptance criteria: pre-commit config has one build-check hook; runtimes clearly faster; ISSUES_RESOLUTION reflects the final state.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions