Context: tests/observer_tests.rs (in the tests/ crate) does use propchain_traits::observer::{EventBus, EventKind, EventObserver}; contracts/traits/src/lib.rs now ships event_bus and dropped observer, and no tests/lib.rs mod pulls observer_tests in - so the file is both stale and dead.
Problem: The EventBus abstraction the tests describe is gone (or renamed), so a future fix the compile attempt will fail; meanwhile the test suite covers nothing about event fan-out, leaving the event_bus replacement untested.
Proposed approach: Either rewire observer_tests.rs to the traits::event_bus implementation and register it in tests/lib.rs, or delete it and add equivalents testing the new bus.
Acceptance criteria: tests crate compiles with the file wired (or file removed); event_bus fan-out has its own tests.
Context:
tests/observer_tests.rs(in thetests/crate) doesuse propchain_traits::observer::{EventBus, EventKind, EventObserver};contracts/traits/src/lib.rsnow shipsevent_busand droppedobserver, and notests/lib.rsmodpullsobserver_testsin - so the file is both stale and dead.Problem: The
EventBusabstraction the tests describe is gone (or renamed), so a futurefix the compileattempt will fail; meanwhile the test suite covers nothing about event fan-out, leaving theevent_busreplacement untested.Proposed approach: Either rewire
observer_tests.rsto thetraits::event_busimplementation and register it intests/lib.rs, or delete it and add equivalents testing the new bus.Acceptance criteria: tests crate compiles with the file wired (or file removed);
event_busfan-out has its own tests.