Eye changes#385
Open
BenReed161 wants to merge 2 commits into
Open
Conversation
Add error cases for Eye capture to avoid error messages that are difficult to decode. Added a command to poll for the eye capture and wait for the timeout. Eye captures on i2c were taking longer than expected. Add error for an inprogress eye. Update gen6 refclk input variable from 0 to 100000. The value 100000 gives enough sampling time per voltage/phase step to accumulate statistically meaningful error counts. Previous default value of 0 was unhelpful as a default value, as 0 sampling time did not give enough time. Add validation check of the gen6 refclk value.
switchtec_gen6_diag_eye_run_in had lane_mask[4] but Gen6 firmware expected lane_mask[5] for 160 bits to cover all 160 lanes. This caused values to be misread as it was offset incorrectly in input structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.