Update parameters for logical network creation#4276
Open
kerimhanif wants to merge 1 commit intoMicrosoftDocs:mainfrom
Open
Update parameters for logical network creation#4276kerimhanif wants to merge 1 commit intoMicrosoftDocs:mainfrom
kerimhanif wants to merge 1 commit intoMicrosoftDocs:mainfrom
Conversation
Fixed CLI syntax in static logical network example. Added missing space between --no-gateway and --ip-pool-start. Corrected undefined PowerShell variable $fabricResourceID in the example.
Contributor
|
Learn Build status updates of commit 52567d2: ✅ Validation status: passed
For more details, please refer to the build report. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the multi-rack “static logical network” documentation example to ensure the provided CLI snippet is syntactically correct and the referenced variables are defined.
Changes:
- Replaced an unused/incorrect internal network variable with
$fabricResourceIDin the parameter setup. - Fixed the
az stack-hci-vm network lnet createexample so flags are correctly spaced/continuous (no broken line). - Reordered IP pool variables and normalized the “Next steps” list formatting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```azurecli | ||
| $lnetName = "mylocal-lnet-static" | ||
| $internalNetworkName = "<Layer 3InternalNetwork>" | ||
| $fabricResourceID = "<Layer 3InternalNetworkID>" |
Contributor
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
Bot
added
the
aq-pr-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed CLI syntax in static logical network example. Added missing space between --no-gateway and --ip-pool-start. Corrected undefined PowerShell variable $fabricResourceID in the example.
Changed the order in the variable list, moved $ipPoolStart to the top