fix(native): handle zip-framed chunk and deque ContentServer pool - #154
Open
SK-DEV-AI wants to merge 1 commit into
Open
fix(native): handle zip-framed chunk and deque ContentServer pool#154SK-DEV-AI wants to merge 1 commit into
SK-DEV-AI wants to merge 1 commit into
Conversation
…ntentServer pool - _decompress_chunk: some shared redist depots (e.g. 228990 _CommonRedist/DirectX) store chunks as PK zip with single entry 'z' instead of VZa/VSZa. Previously raised ValueError unknown chunk magic and failed 0/203 for every game pulling that depot (Sekiro 203/203 repro). Now unzips and falls back to stored-uncompressed with SHA1 validation. - _get_cdn_servers: steam 2.x returns deque[ContentServer(host,https)] not list[dict]; isinstance(raw,list) collapsed ~17 Valve edges to single steampipe host causing throttling. Normalize both shapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two native downloader fixes that hit every user after the steam lib update.
1. zip-framed chunk
PK(depot 228990 etc.)Some shared redist depots (e.g.
228990 _CommonRedist/DirectX/Jun2010) store chunks asPK\x03\x04zip with a single entryzinstead ofVZa/VSZa._decompress_chunkraisedValueError: unknown chunk magic 504b0304and the whole depot failed0/203(Sekiro repro: every run, every mirror). Fix unzips the single entry; unknown magic falls back to stored-uncompressed with caller SHA1 as guard — matches what Steam does.2.
deque[ContentServer]poolsteam 2.x(solsticegamestudios) returnsdeque[ContentServer(host, https)], notlist[dict].isinstance(raw, list)collapsed the~17Valve edges to the singlesteampipefallback and got throttled mid-download. Fix normalizes both shapes to[{"host","https_support"}].Verified on SteaMidra 6.6.6 against Sekiro (
228990 203/203after fix) and full228990SHA1 repro; no wrapper-specific code.