Skip to content

fix(app): ProgressModule is registered twice in AppModule imports #658

Description

@phertyameen

Summary

backend/src/app.module.ts lists ProgressModule twice in its imports array:

ProgressModule,
...
RedisModule,
BlockchainModule,
ProgressModule,   // duplicate
CategoriesModule,

NestJS deduplicates modules internally so this is not fatal at runtime, but it is misleading: readers auditing module wiring (e.g. when tracing the progress-to-analytics event flow) may believe two distinct configurations exist, and linters/reviewers waste cycles flagging it.

Fix

Remove the second occurrence and keep the single registration next to the other feature modules. While there, consider alphabetizing the imports array so future duplicates are obvious.

Acceptance criteria

  • ProgressModule appears exactly once in AppModule.imports.
  • npm --workspace backend run build passes.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions