Repository navigation
Fold the integration fixture database into Store - #450
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
*Storethe only integration test fixture value. Follow-up to #449, from minor 3 of its review.fixtureDB, which duplicatedStore's pool, key and placement rules, along with thenew*TestStoreDBwrappers that paired the two.Store.placement. Before,fixtureSessionsbuilt its own rules from a separate public URL, so a test could set one source and silently get the other.sessionAdapter) and one Session service constructor (newSessionService).publicHandleruses a single Session service forSessionsandSessionCreation, ascmd/serverdoes.Checks:
go build ./...,go vet ./services/core/..., gofmt andcheck-names.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.