Skip to content

Fold the integration fixture database into Store - #450

Merged
SaladDay merged 1 commit into
mainfrom
refactor/integration-fixture
Oct 6, 2026
Merged

SaladDay merged 1 commit into
mainfrom
refactor/integration-fixture

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Makes *Store the only integration test fixture value. Follow-up to #449, from minor 3 of its review.

  • Deleted fixtureDB, which duplicated Store's pool, key and placement rules, along with the new*TestStoreDB wrappers that paired the two.
  • Placement rules now come from one place, Store.placement. Before, fixtureSessions built its own rules from a separate public URL, so a test could set one source and silently get the other.
  • One sessionpg constructor (sessionAdapter) and one Session service constructor (newSessionService). publicHandler uses a single Session service for Sessions and SessionCreation, as cmd/server does.
  • Test-only, mechanical edits. No assertion changed, and no production code changed.

Checks:

  • go build ./..., go vet ./services/core/..., gofmt and check-names.
  • All three integration shards with the database: 411 tests, 379 pass, 32 skip (official SDK, native daemon and operator binary only), 0 fail.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@SaladDay
SaladDay merged commit 0782008 into main Oct 6, 2026
19 checks passed
@SaladDay
SaladDay deleted the refactor/integration-fixture branch October 6, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant