Repository navigation
Reuse the process codec for the trampoline - #451
Merged
Merged
Conversation
The trampoline now receives the operation's encoded StartRequest and decodes it with sandboxprocess.Decode, deriving argv, environment, TERM and PATH at the child boundary, so its private launch format and the second copy of PATH go. It reads the request with io.ReadAll on an owned *os.File. Startup failures wrap their cause with fmt.Errorf naming the step; StartupError and Step had no reader.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B4 simplicity audit, lane L2: the sandbox side. Net −96 production lines.
StartRequestand decodes it withsandboxprocess.Decode. Exec argv, env,TERMand PATH are derived at the child boundary. This removes the private launch format (encodeLaunchanddecodeLaunch) and the second copy of PATH. The request is read withio.ReadAllon an owned*os.File. The trampoline, the child-side umask, descriptor protection and the exec-status pipe are unchanged.StartupErrorandStephad no reader, so they becomefmt.Errorf("<step>: %w", err). The message still names the step and never carries the credential, and a new table test asserts both.Testing:
apps/sandboxiotests;-race -count=20;processbrokersuite (unprivileged and privileged), which drives the trampoline throughprocessserve;Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.