Repository navigation
Admit no protocol upgrade on a model route - #452
Merged
SaladDay merged 1 commit intoOct 6, 2026
Merged
Conversation
Every declared model route left Route.WebSocket false, and the gateway was its only reader. The field is gone: no model route admits a protocol upgrade, and the gateway rejects every upgrade on the model listener with 400 before it reaches the upstream. The Harness–Model provider protocol says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a Harness–Model provider protocol change from the B4 simplicity audit.
modelprovider.Route.WebSocketis deleted. No declared route set it, and its only reader was the gateway's upgrade check. The gateway now rejects every protocol upgrade on a model route. MCP and the proxy still relay upgrades.The change touches:
internal/modelprovider/config.go;apps/daemon/internal/gateway/model.go;contracts/agents-api/model-execution.mdand its zh translation, with a currentsource_hash.TestModelRejectsUndeclaredRequests, which includes upgrade rejection, is unchanged and passes.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.